fix: improve formatting of minutes in build time#5555
Merged
chenjiahan merged 1 commit intomainfrom Jul 7, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the prettyTime helper to display minutes and seconds instead of decimal minutes, and adjusts tests to match the new output format.
- Changed formatting logic to split minutes and remaining seconds
- Updated tests to verify minute-only and minute-second cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/helpers/index.ts | Refactored prettyTime to use Math.floor for minutes and show leftover seconds |
| packages/core/tests/helpers.test.ts | Adjusted test expectations for new minute/second format |
Comments suppressed due to low confidence (2)
packages/core/tests/helpers.test.ts:94
- Consider adding a test for exactly 60 seconds (e.g.,
expect(prettyTime(60)).toEqual('1 m');) to cover the boundary where remainingSeconds === 0.
expect(prettyTime(120)).toEqual('2 m');
packages/core/src/helpers/index.ts:349
- [nitpick] Using strict equality against
0on floating-point values can be brittle; consider usingNumber.isInteger(remainingSeconds)to guard against precision errors.
if (remainingSeconds === 0) {
9aoy
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
prettyTimefunction to improve how time is formatted for better readability and accuracy.20.57 m20 m 34 sChecklist