Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes duplicated “build started…” logs by only tapping the run hook on the first compiler instance in multi-compiler mode.
- Introduces
firstCompilerto select either the sole compiler or the first entry inMultiCompiler.compilers - Moves the
runhook registration tofirstCompilerso logs are emitted only once
Comments suppressed due to low confidence (1)
packages/core/src/provider/createCompiler.ts:123
- Add a unit or integration test for a multi-compiler scenario to verify that only one "build started..." log is emitted.
const firstCompiler = isMultiCompiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the issue of duplicate build start logs being printed when running
rsbuild buildand using theenvironmentsconfiguration.Checklist