fix(plugin-svelte): should transpile JS code in .svelte files#5270
Merged
chenjiahan merged 2 commits intomainfrom May 19, 2025
Merged
fix(plugin-svelte): should transpile JS code in .svelte files#5270chenjiahan merged 2 commits intomainfrom
chenjiahan merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables transpilation of JavaScript inside .svelte files by reusing the existing SWC loader when targeting Svelte v5.
- Pull SWC loader config from the JS rule and apply it to the Svelte rule if
svelte5is enabled - Ensure the Svelte loader chain is properly terminated with
.end() - Exclude Svelte-generated JS/TS files from the main JS rule to avoid double-processing
Comments suppressed due to low confidence (2)
packages/plugin-svelte/src/index.ts:123
- There are no tests covering the new code path for
svelte5JS transpilation in.sveltefiles. Add unit tests to prevent regressions.
if (svelte5 && jsRule) {
packages/plugin-svelte/src/index.ts:114
- Update the function’s JSDoc or README to document the new SWC-based JS transpilation behavior for
.sveltefiles whensvelte5is enabled.
export function pluginSvelte(options: PluginSvelteOptions = {}): RsbuildPlugin {
This was referenced May 19, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
swc-loaderto transpile JavaScript code in.sveltefiles to ensure that the compiled JS code can be downgraded as expected.More test cases will be added in later PRs.
Related Links
https://discord.com/channels/977448667919286283/1167025132905173063/1373701903644622878
Checklist