feat: support dev.lazyCompilation.serverUrl use '<port>' placeholder#5035
Merged
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom Apr 16, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
b1fd1fd to
34ef886
Compare
This was referenced Apr 16, 2025
2 tasks
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Although Rsbuild doesn't directly support setting dev.lazyCompilation with a custom
serverUrl, we can leverageapi.modifyRsbuildConfigto modify bothassetPrefixanddev.lazyCompilation.serverUrl. However, there's an inconsistency:assetPrefixwill find and replace<port>placeholders, whiledev.lazyCompilation.serverUrldoes not perform this replacement, leading to configuration mismatches.Therefore, in the
lazyCompilationMiddleware, we need to check if is present in the URL, and if so, we need to replace it.Related Links
Checklist