fix(server)!: should respect the value of the server.cors option#4876
Merged
chenjiahan merged 5 commits intomainfrom Mar 26, 2025
Merged
fix(server)!: should respect the value of the server.cors option#4876chenjiahan merged 5 commits intomainfrom
server.cors option#4876chenjiahan merged 5 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9aoy
approved these changes
Mar 26, 2025
This was referenced Mar 26, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The Rsbuild dev server unexpectedly set
Access-Control-Allow-Originto*by default, which caused theserver.corsoption not to work as expected and introduced security risks.This PR removes the default
Access-Control-Allow-Origin: *and strictly enables CORS according to the value ofserver.cors.This may break users who are using Module Federation or proxy tools, so I added compatibility code for Module Federation.
Migration
To enable CORS, set server.cors to
true:Related Links
Checklist