Skip to content

test(e2e): replace fs.rmSync with async remove from fs-extra#4805

Merged
chenjiahan merged 2 commits intomainfrom
e2e_remove_0316
Mar 17, 2025
Merged

test(e2e): replace fs.rmSync with async remove from fs-extra#4805
chenjiahan merged 2 commits intomainfrom
e2e_remove_0316

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

fse.remove is less verbose and can avoid exceptions caused by forgetting to add force: true.

Fix flaky cases like:

Screenshot 2025-03-16 at 13 09 12

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 16, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 5fab618
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67d6cccffd4e2400086d51f2
😎 Deploy Preview https://deploy-preview-4805--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🟢 up 13 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit bb18077 into main Mar 17, 2025
12 checks passed
@chenjiahan chenjiahan deleted the e2e_remove_0316 branch March 17, 2025 01:11
@chenjiahan chenjiahan mentioned this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant