Skip to content

test(e2e): remove ESM syntax to fix timeout#4624

Merged
chenjiahan merged 3 commits intomainfrom
e2e_fix_0221
Feb 21, 2025
Merged

test(e2e): remove ESM syntax to fix timeout#4624
chenjiahan merged 3 commits intomainfrom
e2e_fix_0221

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan commented Feb 21, 2025

Summary

Remove ESM usages to fix E2E timeout.

Possible causes:

  1. Playwright <= 1.45 has a bug when handling dynamic imports, causing import(rsbuild.config.mjs) to fail.

microsoft/playwright#31140

image

  1. If the dynamic import fails, rsbuild.config.mjs is loaded through jiti, but jiti v1 doesn't support import.meta.* yet:

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 21, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 0bd43ec
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67b8847a8c5e140008e06c21
😎 Deploy Preview https://deploy-preview-4624--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 61 (🟢 up 12 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan changed the title test(e2e): remove ESM usages to fix timeout test(e2e): remove ESM syntax to fix timeout Feb 21, 2025
@chenjiahan chenjiahan merged commit 7582615 into main Feb 21, 2025
11 checks passed
@chenjiahan chenjiahan deleted the e2e_fix_0221 branch February 21, 2025 14:22
@chenjiahan chenjiahan mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant