fix(plugin-assets-retry): avoid __webpack_require__.e pollution and add some try catch to be safer#4025
Merged
fix(plugin-assets-retry): avoid __webpack_require__.e pollution and add some try catch to be safer#4025
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
8dd461e to
dbea40c
Compare
9aoy
approved these changes
Nov 21, 2024
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if apps use preload,
__webpack_require__.ewould have other argumentsfetchPriority, that would cause the errorhttps://github.com/web-infra-dev/rspack/blob/530a068b9fa461da27b07e5a1fa3ca94f296d7b0/crates/rspack_plugin_runtime/src/runtime_module/runtime/ensure_chunk.js#L4
__webpack_require__.ewith some argstry catchlogic to make saferRelated Links
Checklist