✅ Deploy Preview for rsbuild ready!

Name	Link
🔨 Latest commit	6343911
🔍 Latest deploy log	https://app.netlify.com/sites/rsbuild/deploys/667bb056998878000887a02d
😎 Deploy Preview	https://deploy-preview-2708--rsbuild.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 86 (🔴 down 2 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan According to https://github.com/webpack-contrib/sass-loader?tab=readme-ov-file#additionaldata, it can also be just a string.
With this change, it can only be a function.

my mistake, I will fix it

FYI I suggested a PR to fix that on DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#70037

Nice 👍🏻

FYI I suggested a PR to fix that on DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#70037

It has been merged an release in the last version of @types/sass-loader 🎉

Awesome, can you submit a PR to bump version and remove the override types? ❤️

I think Rsbuild can still retain the type overrides, as @types/sass-loader depends on webpack.LoaderContext but Rsbuild should use Rspack.LoaderContext.

Thanks for the changes 🙌