[Bug]: Cannot capture SIGINT(Ctrl+C) #2112
Description
Version
npmPackages:
@rsbuild/core: ^0.6.0 => 0.6.0
@rsbuild/plugin-react: ^0.6.0 => 0.6.0Details
I would like to capture the SIGINT(Ctrl+C) in my app built with Rsbuild. After adding process.on('SIGINT', callback), it seems like the process still exits when Ctrl+C is pressed.
I took a look at the Rsbuild's code, Rsbuild is also listening to the 'SIGINT' signal and calls process.exit inside the callback.
rsbuild/packages/shared/src/utils.ts
Lines 289 to 291 in defa5d4
I could remove the listener after the call to createRsbuild() and startDevServer() using process.removeAllListeners('SIGINT'). But this makes the code handling process exit split into two places:
src/exit.js
import { asyncExitHook, gracefulExit } from 'exit-hook';
const unsubscribe = asyncExitHook(onExit, { wait: 1000 });
// Cannot do process.on('SIGINT') here.
process.on('unhandledRejection', async (reason) => {
unsubscribe();
await onExit(1);
process.exit(1);
});src/rsbuild.js
const rsbuild = await createRsbuild({ cwd, rsbuildConfig })
const server = await rsbuild.createDevServer()
// Rsbuild has an exit listener on `SIGINT` and directly call process.exit(0)
// We remove it from here
process.removeAllListeners('SIGINT')
let interrupted = false
process.on('SIGINT', () => {
if (interrupted) {
return process.exit(/** 128 + 2(kill) */ 130)
}
interrupted = true
logger.info(
`Gracefully shutting down. Please wait... (Press ${
color.cyan('Ctrl+C')
} again to force exit)`,
)
exit(/** 128 + 2(kill) */ 130)
})It would be nice if Rsbuild could remove this SIGINT exit listener. So that I could capture SIGINT in my exit.js.
Reproduce link
https://github.com/web-infra-dev/rsbuild/tree/main/examples/react
Reproduce Steps
- Use the simplest example
- Add a
SIGINTlistener inrsbuild.config.ts
E.g.:
import { logger } from '@rsbuild/core'
let interrupted = false
process.on('SIGINT', () => {
if (interrupted) {
return process.exit(/** 128 + 2(kill) */ 130)
}
interrupted = true
logger.info(
`Gracefully shutting down. Please wait... (Press Ctrl+ C again to force exit)`,
)
})- Run
rsbuild devand try exit using Ctrl+C
Expected: the log is printed and the process is not exited
Actual: the process exited