flat index: Add support for RQ and include cache param #1844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
9c62e9e to
3ad603f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/1.34 #1844 +/- ##
===========================================
Coverage ? 86.56%
===========================================
Files ? 273
Lines ? 19190
Branches ? 0
===========================================
Hits ? 16612
Misses ? 2578
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dirkkul
reviewed
Oct 13, 2025
Collaborator
dirkkul
left a comment
There was a problem hiding this comment.
Can you:
- target this to dev/1.34 (doesn not exist yet, just branch off main)
- add a pre-release version of 1.34 to our CI? Otherwise all the tests wont run
cdd5992 to
97a4c21
Compare
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
f6b6641 to
deff7c5
Compare
deff7c5 to
392aa97
Compare
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the usage of the client to support RQ with flat index.
To do so, include the cache param and also extend the update functions.
The PR also adds a helper function to retry in case of HTTP error due to flakiness in the CI