Add support for exists on aliases. #1813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
f0f73b5 to
92feb90
Compare
dirkkul
reviewed
Sep 2, 2025
weaviate/aliases/executor.py
Outdated
| try: | ||
| self.get(alias_name=alias_name) | ||
| return True | ||
| except Exception: |
Collaborator
There was a problem hiding this comment.
I think we should not catch all exceptions, for example when the client cannot connect or is unauthenticated this can be a footgun (which Daniel found out a couple of weeks ago: #1799)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
==========================================
- Coverage 87.27% 86.80% -0.48%
==========================================
Files 269 273 +4
Lines 18778 19059 +281
==========================================
+ Hits 16389 16544 +155
- Misses 2389 2515 +126 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d4fd5f0 to
b3dabec
Compare
dirkkul
approved these changes
Sep 4, 2025
It is quite useful to know if an alias is present on the system or not. Also, it is consistent with other classes which always contain an exists method.
b3dabec to
bdc6481
Compare
Contributor
Author
|
I've tested the changes by using the branch on the sim envs as well as the e2e tests and it's working like a charm. |
dirkkul
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is quite useful to know if an alias is present on the system or not. Also,
it is consistent with other classes which always contain an exists method.