Skip to content

feat: add Not and ContainsNone operators #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bevzzz merged 13 commits into from
Sep 1, 2025
Merged

feat: add Not and ContainsNone operators #1809

bevzzz merged 13 commits into from
Sep 1, 2025

Conversation

@bevzzz
Copy link
Contributor

@bevzzz bevzzz commented Sep 1, 2025 •
edited
Loading

The majority of changed files are due to the regenerated protobufs.

ContainsNone

ContainsNone is available wherever ContainsAny is.

wvc.query.Filter.by_property("test").contains_none([1, 2, 3])
wvc.query.Filter.by_id().contains_none(["uuid-1", "uuid-2"])
wvc.query.Filter.by_creation_time("test").contains_none([...])

Not

Operator Not can only have 1 argument, which is "enforced" with type hints, but not actively validated.

cond = wvc.query.Filter.by_id().any_of('a', 'b')
not_cond = wvc.query.Filter.not_(cond) # accepts _Filters, not list<_Filters>

# also supports bitwise invert operator as "not"
not_cond = ~cond

orca-security-eu[bot]
orca-security-eu bot reviewed Sep 1, 2025
View reviewed changes
Copy link

@orca-security-eu orca-security-eu bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@bevzzz bevzzz force-pushed the feat/not-containsnone branch from a17550e to f0e8b5c Compare September 1, 2025 12:26
@tsmith023 tsmith023 changed the base branch from main to dev/1.33 September 1, 2025 12:41
@tsmith023 tsmith023 requested a review from a team as a code owner September 1, 2025 12:41
orca-security-eu[bot]
orca-security-eu bot reviewed Sep 1, 2025
View reviewed changes
Copy link

@orca-security-eu orca-security-eu bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.59574% with 11 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (dev/1.33@a66e8fb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
weaviate/collections/classes/filters.py 64.00% 9 Missing ⚠️
weaviate/collections/filters.py 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             dev/1.33    #1809   +/-   ##
===========================================
  Coverage            ?   86.97%           
===========================================
  Files               ?      273           
  Lines               ?    19011           
  Branches            ?        0           
===========================================
  Hits                ?    16535           
  Misses              ?     2476           
  Partials            ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bevzzz bevzzz merged commit 82ba7f7 into dev/1.33 Sep 1, 2025
117 checks passed
@bevzzz bevzzz deleted the feat/not-containsnone branch September 1, 2025 17:05
@dirkkul dirkkul mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orca-security-eu orca-security-eu[bot] orca-security-eu[bot] left review comments

@tsmith023 tsmith023 tsmith023 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bevzzz @codecov-commenter @tsmith023