Skip to content

Conversation

@dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Aug 6, 2025

closes #1697

To test:

semitechnologies/weaviate:1.32.2-09ac6c5.amd64
semitechnologies/weaviate:1.32.2-09ac6c5.arm64
  • assign roles to groups client.groups.oidc.assign_roles(...) - revoke roles from groups client.groups.oidc.revoke_roles(…) - get roles for a group client.groups.oidc.get_assigned_roles(...)
  • get all known groups (==OIDC groups that have roles assigned) client.groups.oidc.get_known_group_names() - get all groups that are assigned to a role client.roles.get_group_assignments(...) - own user info also contains roles from groups now: client.roles.get_current_roles() - Groups have their own separate permissions: Permissions.Groups.oidc(group="MyGroup", read=True)

@dirkkul dirkkul requested a review from a team as a code owner August 6, 2025 19:57
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 58.85417% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.95%. Comparing base (c7b8c75) to head (96ca93c).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
integration/test_groups.py 30.00% 42 Missing ⚠️
weaviate/groups/base.py 43.18% 25 Missing ⚠️
weaviate/rbac/models.py 85.10% 7 Missing ⚠️
weaviate/rbac/executor.py 20.00% 4 Missing ⚠️
weaviate/users/base.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1778      +/-   ##
==========================================
- Coverage   87.27%   86.95%   -0.33%     
==========================================
  Files         269      273       +4     
  Lines       18778    18985     +207     
==========================================
+ Hits        16389    16508     +119     
- Misses       2389     2477      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsmith023 tsmith023 merged commit f4f7666 into main Sep 1, 2025
119 of 121 checks passed
@tsmith023 tsmith023 deleted the oidc_groups branch September 1, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for RBAC group role assignment

4 participants