Acorn1#5369
Merged
abdelr merged 23 commits intostable/v1.27from Oct 15, 2024
Merged
Conversation
|
trengrj
reviewed
Oct 7, 2024
3f628f6 to
9ff18a2
Compare
trengrj
reviewed
Oct 11, 2024
trengrj
reviewed
Oct 11, 2024
trengrj
reviewed
Oct 11, 2024
trengrj
reviewed
Oct 11, 2024
asdine
reviewed
Oct 11, 2024
robbespo00
reviewed
Oct 14, 2024
trengrj
reviewed
Oct 14, 2024
…dd tests for acorn params. Only use acorn params when needed.
Minor ACORN fixes
|
trengrj
approved these changes
Oct 15, 2024
asdine
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What's being changed:
This PR introduces an ACORN1 like search.
Important features taken from ACORN are:
What we do not do from ACORN:
What to expect from the implementation:
Finally, we add some tests with the super beir data. In the chart, Main stands for the old logic, while ACORN stands for the new logic, and the suffix indicate whether we use positive or negative correlation for the filter.

Review checklist