Merged
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
dirkkul
reviewed
Dec 30, 2025
src/collections/configure/index.ts
Outdated
| enabled?: boolean; | ||
| deleteOn?: string; | ||
| deleteOnCreatedTime?: boolean; | ||
| deleteOnUpdateTime?: boolean; |
Collaborator
There was a problem hiding this comment.
This could be confusing as you can only choose one of these options. Eg you either delete on a property OR on creation time OR on update time. That's why the other clients have the factory methods to select one of these with different options (defaultTTLSeconds is required for creation time + update time but not property)
src/collections/configure/index.ts
Outdated
| }; | ||
| }, | ||
| objectTTL: (options?: { | ||
| enabled?: boolean; |
Collaborator
There was a problem hiding this comment.
I also would not add enabled as an option here. If you set TTL for creation it is enabled
dirkkul
approved these changes
Dec 30, 2025
Collaborator
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Object TTL configuration in collections.