Skip to content

feat: add support for multi2multivec-jinaai vectorizer#317

Merged
tsmith023 merged 5 commits intomainfrom
feat/multi2multivec-jinaai
Jul 16, 2025
Merged

feat: add support for multi2multivec-jinaai vectorizer#317
tsmith023 merged 5 commits intomainfrom
feat/multi2multivec-jinaai

Conversation

@bevzzz
Copy link
Collaborator

@bevzzz bevzzz commented Jul 11, 2025

➡️ Merge after #315. There are some CI configuration updates and test fixes.

Weaviate 1.32 is going to feature multi2multivec-jinaai module. With this PR it will be possible to configure it in a TS project.

Use it like this:

configure.vectorizer.multi2MultivecJinaAI({
    name: 'multi-jina',
    imageFields: ['field1', 'field2'],
    textFields: ['field3', 'field4'],
})

orca-security-eu[bot]
orca-security-eu bot reviewed Jul 11, 2025
View reviewed changes
Copy link

@orca-security-eu orca-security-eu bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@bevzzz bevzzz requested a review from tsmith023 July 11, 2025 15:56
@tsmith023
Copy link
Collaborator

tsmith023 commented Jul 14, 2025

Let's keep this in draft until #264 and #318 are merged to ensure no conflicts

@tsmith023
Copy link
Collaborator

tsmith023 commented Jul 15, 2025 •
edited
Loading

Given the introduction of the configure.multiVectors factory in #264, I think this PR should be modified to match the new API. wdyt? @bevzzz

@bevzzz bevzzz force-pushed the feat/multi2multivec-jinaai branch from 8987ae4 to 3e28211 Compare July 15, 2025 14:53
@bevzzz
Copy link
Collaborator Author

bevzzz commented Jul 15, 2025 •
edited
Loading

Given the introduction of the configure.multiVectors factory in #264

@tsmith023 since those changes haven't been released yet, do you think it'll make sense to rename multiVectors.text2VecJinaAI to multiVectors.text2MultivecJinaAI? Because the module is called text2multivec-jinaai and the convention is to name the static factory after the module.

I think it's more consistent this way

@bevzzz bevzzz marked this pull request as ready for review July 15, 2025 15:05
@tsmith023
Copy link
Collaborator

tsmith023 commented Jul 16, 2025 •
edited
Loading

multiVectors.text2VecJinaAI to multiVectors.text2MultivecJinaAI

@bevzzz, the idea of dropping the MultiVec here is because it is already used in the multiVectors factory name so is redundant information. I would agree that it should be text2MultiVecJinaAI if the method was under vectors, however

@bevzzz
Copy link
Collaborator Author

bevzzz commented Jul 16, 2025

the idea of dropping the MultiVec here is because it is already used in the multiVectors factory name

I renamed the static factory for the new module to multi2VecJinaAI to be consistent with the other example

@tsmith023 tsmith023 merged commit cf877ad into main Jul 16, 2025
18 checks passed
@tsmith023 tsmith023 deleted the feat/multi2multivec-jinaai branch July 16, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orca-security-eu orca-security-eu[bot] orca-security-eu[bot] left review comments

@antas-marcin antas-marcin antas-marcin approved these changes

@tsmith023 tsmith023 tsmith023 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bevzzz @tsmith023 @antas-marcin