Support adding named vectors to a collection#299
Merged
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
Run the new integration test only if the server is > 1.31.0
They are immutable in Weaviate and will cause an error
tsmith023
reviewed
Jun 2, 2025
tsmith023
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
collection.config.addVectormethod to support creating new named vectors on the collection. Only named vectors can be created and existing named vectors cannot be modified.The method accepts the same arguments as
collections.create(... { vectorizers: XXX })with the exception that anonymous vectors are not permitted, e.g.vectorizer.none().single objectand passing it as an array[single object]tocollections.create()would result in 2 different behaviors: custom name changed todefaultvs custom name preserved.