Skip to content

Conversation

@bevzzz
Copy link
Collaborator

@bevzzz bevzzz commented Oct 3, 2025

The second part of the Sort integration test check how objects can be sorted by their created/last-updated time. These sort of assertions are extremely error prone, as they depend on the server's timing.

This does little to test client's correctness and ends up failing pipelines in many other PRs. Some time later we may add a test suite for converting request objects to gRPC, where we can verify the correctness, but for now the costs (failed pipelines) outweigh the benefits.

@bevzzz bevzzz self-assigned this Oct 3, 2025
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@bevzzz bevzzz merged commit 49d5091 into v6 Oct 3, 2025
2 checks passed
@bevzzz bevzzz deleted the v6-drop-flaky-test branch October 3, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants