v6: Use float[] instead of Float[] for vectors #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We started off using Float[] and Float[][] because v5 did so and it was easier to reuse (read: copy-paste) some bits of code. Thing with object arrays is that they name N allocations (1 for each element) compared to 1 that a primitive array makes. That creates unnecessary work for GC and we aren't gaining anything from using boxed values. They're still useful for request parameters like distance/certainty/force, because they can be null. But vectors are not sparse and should never contain nulls in principle.
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
antas-marcin
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces usages of
Float[]andFloat[]with their primitive doubles across the client. We do not gain anything from working with objects here and only create unnecessary for the GC. See 7cfcb6b for details.Some small cleanups and refactors too.
Resolves #424