Skip to content

feat: Support collection aliases #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bevzzz merged 8 commits into from
Jul 10, 2025
Merged

feat: Support collection aliases #409

bevzzz merged 8 commits into from
Jul 10, 2025

Conversation

@bevzzz
Copy link
Collaborator

@bevzzz bevzzz commented Jul 9, 2025 •
edited
Loading

This PR adds API for managing collection aliases and extends the set of permissions with AliasesPermissions.

Manage aliases

client.aliases().creator().withClassName("Pizza").withAlias("PizzaPie").run();
client.aliases().allGetter().run();
client.aliases().getter().withAlias("PizzaPie").run();
client.aliases().updater().withAlias("PizzaPie").withNewClassName("Langos").run();
client.aliases().deleter().withAlias("PizzaPie").run();

Manage alias permissions

.withPermissions(
    Permission.aliases("PizzaPie", AliasesPermission.Action.CREATE, AliasesPermission.Action.DELETE)
);

@bevzzz bevzzz requested a review from antas-marcin July 9, 2025 13:14
@bevzzz bevzzz self-assigned this Jul 9, 2025
orca-security-eu[bot]
orca-security-eu bot reviewed Jul 9, 2025
View reviewed changes
Copy link

@orca-security-eu orca-security-eu bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@bevzzz bevzzz marked this pull request as ready for review July 10, 2025 07:53
antas-marcin
antas-marcin reviewed Jul 10, 2025
View reviewed changes
bevzzz added 3 commits July 10, 2025 10:26
@bevzzz
test: fix expected action value
8783c8b
@bevzzz
chore: implement review feedback
3861e7e 
1. Rename client.aliases() -> client.alias()
Same for AliasesPermission and Permission.aliases: convert them to singular.

2. Add optional query parameter in 'get all' method to only fetch
   aliases declared for a collection.
@bevzzz
fix: typo in tests
70733c7
@bevzzz bevzzz merged commit 2a4065a into main Jul 10, 2025
5 checks passed
@bevzzz bevzzz deleted the feat/collection-alias branch July 10, 2025 13:40
@bevzzz bevzzz mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orca-security-eu orca-security-eu[bot] orca-security-eu[bot] left review comments

@antas-marcin antas-marcin antas-marcin approved these changes

Assignees

@bevzzz bevzzz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bevzzz @antas-marcin