Skip to content

Add documentation for Instance Selector#3498

Merged
cPu1 merged 2 commits intoeksctl-io:mainfrom
cPu1:instance-selector-doc
Mar 31, 2021
Merged

Add documentation for Instance Selector#3498
cPu1 merged 2 commits intoeksctl-io:mainfrom
cPu1:instance-selector-doc

Conversation

@cPu1
Copy link
Copy Markdown
Contributor

@cPu1 cPu1 commented Mar 31, 2021

Description

Adds documentation for the instance selector feature.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cPu1 cPu1 added area/docs skip-release-notes Causes PR not to show in release notes labels Mar 31, 2021
@cPu1
Copy link
Copy Markdown
Contributor Author

cPu1 commented Mar 31, 2021

Tests will fail because the example uses the instanceSelector field and the PR for that isn't merged yet.

@cPu1 cPu1 force-pushed the instance-selector-doc branch from 298c888 to ed526a3 Compare March 31, 2021 13:40
Copy link
Copy Markdown
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cPu1 cPu1 enabled auto-merge March 31, 2021 13:52
@cPu1 cPu1 merged commit dddc9b7 into eksctl-io:main Mar 31, 2021
@cPu1 cPu1 deleted the instance-selector-doc branch April 1, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Causes PR not to show in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants