Reproducable httpgrpc.pb.go build#264
Merged
bboreham merged 3 commits intoweaveworks:masterfrom Nov 24, 2022
Merged
Conversation
01dad76 to
8993d8f
Compare
bboreham
reviewed
Nov 24, 2022
Collaborator
bboreham
left a comment
There was a problem hiding this comment.
Great work! One small request, maybe it can go in a commit message.
|
|
||
| # A 3-year-old image which is a reasonable match for the last time the files were generated. | ||
| PROTOC_IMAGE=namely/protoc:1.22_1 | ||
| PROTOC_IMAGE=namely/protoc:1.23_0 |
Collaborator
There was a problem hiding this comment.
Can you mention somewhere why this changed?
Contributor
Author
There was a problem hiding this comment.
There's 3 small(?) changes in the generated files otherwise, I've noted the most interesting one in the commit message and above in the PR description
Use gogo protobuf options explicitly to generate the same Equal, String, GoString etc functions in the protobug implementation. Add tools.go to download the gogo.proto dependency. Add vendor directory as include for protoc to load the dependency. Update protoc version otherwise there is a diff in the generated files, most notably const _ = proto.GoGoProtoPackageIsVersion3 is replaced with const _ = proto.GoGoProtoPackageIsVersion2 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
This is a simple check to catch if proto generation changes files. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
de0fe1d to
88f68fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproducable httpgrpc.pb.go build
Use gogo protobuf options explicitly to generate the same Equal, String,
GoString etc functions in the protobuf implementation.
Add tools.go to download the gogo.proto dependency.
Add vendor directory as include for protoc to load the dependency.
Update protoc version otherwise there is a diff in the generated files,
most notably
const _ = proto.GoGoProtoPackageIsVersion3
is replaced with
const _ = proto.GoGoProtoPackageIsVersion2
Add check-protos target
This is a simple check to catch if proto generation changes files.
Check generated protobuf files in CI
Signed-off-by: György Krajcsovits gyorgy.krajcsovits@grafana.com