Add straightforward --input #29
Conversation
add -i, --input parameter and processing codes for input file
change help message for --input
change help info for --input
adding input to Cli in tests
|
Thank you! I had to add |
|
Yeah, it won't work for compressed input file. There are too many compressed format such as |
|
@wdecoster If you want such as |
|
That would be great, as I would hope most people keep their fastqs compressed, and gz is definitely the most frequent compression format for such files. But as you said, anyone could just use stdin for things like that :-) |
|
@wdecoster I have added the support for |
use triple backticks
|
Looks great, thanks so much! |
|
@wdecoster There is a typo in the EXAMPLE section I add in readme.md |
|
Hi both! Only seeing this today and was excited to remove a couple pipes. Tried to no avail on an 8-core allocation, while piping still worked - Making a silly mistake here? |
|
I wonder if that is fixed by a later PR that hasn't made it into a release, yet. I will post a new binary ere later today (I hope?) to debug this further... |
|
Can you try with v0.9.0? |
|
-i is working identically to the old pipes for me with 0.9.0. Thanks @wdecoster @JMencius and @sharkLoc too! |
|
Hi @wdecoster Would you mind change this expression in
|
|
Done! |
Hi @wdecoster
I manage to modify the original code to implement the --input mentioned in issue #10.
Breifly I just add an
--inputor-ito accept an input filename and transform to flow and input tofilterfunction.I also test it with
cat {FILEPATH}/test.fastq | ./chopper -q 10 > testQ10_old.fastq; Kept 207 reads out of 250 reads ./chopper -q 10 -i {FILEPATH}/test.fastq > testQ10_new.fastq; Kept 207 reads out of 250 readsThese run give the same result. I hope you like my modifications.