Make use of faster preset and multithreaded minimap2#26
Make use of faster preset and multithreaded minimap2#26wdecoster merged 2 commits intowdecoster:masterfrom Ge0rges:master
Conversation
|
Thank you @Ge0rges! Looks mostly okay, but the automated test reported two errors. Could you take a look at it? If necessary, I can help :) |
|
Checking it out right now |
|
@wdecoster should work now, I forgot to update the test functions. |
|
Looks good! At some point, we should probably deal with the warning here: |
|
Yeah I wasn't sure what that was about so I decided to leave it be for now. |
|
It might be worth mentioning somewhere that we use LrHq in case someone is still using older chemistry. |
|
@wdecoster do you think the PR merits a version bump and package? |
|
Yes, I need to make a new release. Hmm, the older chemistry won't immediately go away. I am not yet sure what the best solution is. |
Switched to using the new version of minimap2 which has the new
LrHqpreset and multithreading.Make use of that 4x faster preset.
Implement multithreading (I think it works?) for #18