packages/core/src/contexts/translations/rxdb-backend.ts (2)

9-11: Consider adding type definitions for better type safety.

The use of any for translationsState, version, and services reduces type safety and IDE support. Consider defining interfaces for these, especially since translationsState appears to have a specific shape (object with language keys and a set method).

🔧 Proposed type definitions

+interface TranslationsState {
+	[language: string]: Record<string, string> | undefined;
+	set?: (language: string, updater: () => Record<string, string>) => void;
+}
+
+interface BackendServices {
+	resourceStore: {
+		addResourceBundle: (lng: string, ns: string, resources: object, deep?: boolean, overwrite?: boolean) => void;
+	};
+}
+
 export class RxDBBackend {
 	static type = 'backend' as const;
 	type = 'backend' as const;

-	private translationsState: any;
-	private version: string;
-	private services: any;
+	private translationsState: TranslationsState | null = null;
+	private version: string = '0.0.0';
+	private services: BackendServices | null = null;

---

40-54: Unhandled background fetch may silently fail without any observability.

The empty .catch(() => {}) swallows all errors, making it difficult to debug translation loading issues in production. Consider adding minimal logging or error tracking.

🔧 Proposed improvement with optional logging

 		fetch(url)
 			.then((response) => {
 				if (!response.ok) return;
 				return response.json();
 			})
 			.then((data) => {
 				if (data && Object.keys(data).length > 0) {
 					const current = this.translationsState?.[language];
 					if (JSON.stringify(current) !== JSON.stringify(data)) {
 						this.translationsState?.set(language, () => data);
 					}
 					this.services.resourceStore.addResourceBundle(language, namespace, data, true, true);
 				}
 			})
-			.catch(() => {});
+			.catch((error) => {
+				// Silently fail for background fetch - translations will use cache or fallback
+				if (__DEV__) {
+					console.warn(`[RxDBBackend] Failed to fetch translations for ${language}/${namespace}:`, error);
+				}
+			});

packages/core/src/contexts/translations/rxdb-backend.test.ts (1)

126-127: Consider using a more robust approach for awaiting promise resolution.

Using setTimeout(r, 0) works but can be flaky in some environments. Consider using jest.runAllTimers() with fake timers, or a utility like flushPromises.

🔧 Example using a flushPromises helper

// Add at top of file
const flushPromises = () => new Promise(jest.requireActual('timers').setImmediate);

// Then use in tests:
await flushPromises();

apps/main/e2e/settings.spec.ts (3)

80-81: Hardcoded waitForTimeout can cause flaky tests.

Using fixed delays like page.waitForTimeout(500) is fragile. Consider waiting for a specific condition instead, such as the filtered results appearing.

🔧 Proposed improvement

 		await searchInput.fill(search);
-		await page.waitForTimeout(500);
-		await page.getByText(label).click();
+		// Wait for the option to appear in the filtered list before clicking
+		const option = page.getByText(label);
+		await expect(option).toBeVisible({ timeout: 5_000 });
+		await option.click();

---

96-100: Consider using the changeLanguage helper here for consistency.

The test duplicates the language change logic that's already encapsulated in the changeLanguage helper defined above. Using the helper would improve maintainability.

🔧 Proposed refactor

 		// The General tab is shown by default with a Language combobox.
-		// The demo store defaults to "English (US)".
-		const languageTrigger = page.getByText('English (US)').first();
-		await expect(languageTrigger).toBeVisible({ timeout: 10_000 });
-		await languageTrigger.click();
-
-		// Search for French in the combobox popover
-		await page.getByPlaceholder('Search Languages').fill('French');
-		await page.waitForTimeout(500);
-
-		// Select "French (Français)" from the filtered list
-		await page.getByText('French (Français)').click();
+		await changeLanguage(page, 'French', 'French (Français)');

---

134-135: Replace hardcoded delay with an explicit wait condition.

The 1-second delay after closing the modal is fragile. Wait for the modal to be hidden or the POS page to be fully visible instead.

🔧 Proposed fix

 		// Close settings modal
 		await page.getByRole('button', { name: /close|fermer/i }).first().click();
-		await page.waitForTimeout(1_000);
+		// Wait for modal to close by checking the POS search is visible
+		await expect(page.getByPlaceholder(/Search Products|Rechercher des produits/i)).toBeVisible({ timeout: 10_000 });

packages/core/src/contexts/translations/index.tsx (1)

42-46: Consider removing the redundant locale change effect.

Since locale is in the useMemo dependency array (line 37), a locale change already creates a new instance initialized with lng: locale. The effect's condition will always be false after instance recreation, making this block effectively dead code.

♻️ Proposed simplification

If the locale-handling via useMemo recreation is intentional, consider removing this effect:

-	/**
-	 * Handle locale changes.
-	 */
-	React.useEffect(() => {
-		if (i18nInstance.language !== locale) {
-			i18nInstance.changeLanguage(locale);
-		}
-	}, [locale, i18nInstance]);
-

Alternatively, if you prefer using changeLanguage for locale updates, remove locale from the useMemo dependencies and rely solely on this effect.