packages/components/src/format-number/format-number.tsx (2)

132-139: Undefined variable index will cause a runtime error.

The getMaskAtIndex callback references index on line 138, but this variable is never defined within the function scope or received as a parameter. This will throw a ReferenceError at runtime.

🐛 Proposed fix to accept index as a parameter

-	const getMaskAtIndex = React.useCallback(() => {
+	const getMaskAtIndex = React.useCallback((index: number) => {
 		const { mask = ' ' } = props;
 		if (typeof mask === 'string') {
 			return mask;
 		}

 		return mask[index] || ' ';
-	}, [props]);
+	}, [props.mask]);

---

172-173: Type mismatch: format function expects number but receives string.

The format prop is typed as (value: number) => string on line 28, but formattedValue is a string. Either update the type signature or convert the value appropriately.

🔧 Option 1: Update type to accept string

-	format?: string | ((value: number) => string);
+	format?: string | ((value: string) => string);

🔧 Option 2: Parse the string to number before calling

 		} else if (typeof format === 'function') {
-			formattedValue = format(formattedValue);
+			formattedValue = format(parseFloat(formattedValue));

packages/core/src/screens/main/pos/cart/table.tsx (1)

208-209: Replace console.log with logger and avoid any type.

Two guideline violations:

1. Line 208: Uses any type—should use a strict type or generic
2. Line 209: Uses console.log—should use the logger library

As per coding guidelines: "Use the logger library exclusively for logging; DO NOT use console.log" and "Do not use 'any' type; use strict types and generics instead."

Proposed fix

+import log from '@wcpos/utils/logger';

 meta: {
-  onChange: (data: any) => {
-    console.log('onChange called without handler', data);
+  onChange: (data: unknown) => {
+    log.warn('onChange called without handler', data);
   },

packages/components/src/format/list.tsx (1)

5-7: Fix the array type definition.

The type array?: [] is an empty tuple type, meaning it can only accept an empty array. This should be a proper array type to allow actual items.

🐛 Proposed fix

 export interface FormatListProps {
-	array?: [];
+	array?: (string | React.ReactNode)[];
 }

packages/core/src/screens/main/products/cells/actions.tsx (1)

1-30: Fix import ordering: move @tanstack/react-table with external deps.

@tanstack/react-table is an external dependency and should be grouped with other externals right after React imports, before @wcpos/* and local imports.

🔧 Suggested reorder

 import * as React from 'react';

 import { useRouter } from 'expo-router';
+import type { CellContext } from '@tanstack/react-table';

 import {
 	AlertDialog,
 	AlertDialogAction,
 	AlertDialogCancel,
@@
 import { Text } from '@wcpos/components/text';

 import { useT } from '../../../../contexts/translations';
 import useDeleteDocument from '../../contexts/use-delete-document';
 import usePullDocument from '../../contexts/use-pull-document';

-import type { CellContext } from '@tanstack/react-table';
-
 type ProductDocument = import('@wcpos/database').ProductDocument;

As per coding guidelines: Enforce import ordering in TypeScript/JavaScript files: React first, then external dependencies, then @wcpos/* internal imports.

packages/core/src/utils/merge-stores.ts (1)

32-121: Add unit tests for this utility function.

This utility handles critical business logic with multiple code paths (store removal, upsert, error handling) and data transformations. Per coding guidelines, utility functions with data transformations and business logic require colocated unit tests in a merge-stores.test.ts file.

packages/core/src/screens/main/products/products.tsx (1)

201-237: Mutable ref pattern violates React Compiler rules; refactor instead of narrowing suppression scope.

The block suppression of react-compiler/react-compiler correctly identifies a violation, but narrowing the scope alone doesn't resolve it. React Compiler bails out of optimization when ESLint suppressions are present, even if narrowed. The deeper issue is that expandedRef is both mutated (lines 205, 207, 218) and used in the meta object passed to JSX (line 222), which violates React Compiler's requirement to avoid reading/writing mutable refs during render.

The comment mentions a TanStack minification bug with computed property destructuring, not a React Compiler limitation. Rather than suppressing the rule, consider:

1. Keeping the ref fully internal without passing it to JSX meta objects, or
2. Converting expandedRef to React state if its value affects rendering, or
3. Using a stable callback wrapper pattern that avoids exposing the mutable ref in dependencies.

Simply adding a // eslint-disable-next-line comment (as shown in the previous suggestion) will still cause the compiler to bail, and the issue will remain unresolved.

packages/utils/src/logger/index.ts (1)

82-105: Replace any with unknown in the safeStringify parameter.

The function safely handles any input type through JSON.stringify and try-catch, making unknown the appropriate choice for type safety.

Proposed change

-function safeStringify(obj: any, maxLength = 10000): string {
+function safeStringify(obj: unknown, maxLength = 10000): string {

packages/core/src/screens/main/components/header/user-menu.tsx (1)

87-89: Replace console.log with logger.

Per coding guidelines, use the logger library exclusively for logging. This console.log should use uiLogger which is already imported.

Proposed fix

 			onChange: (data: any) => {
-				console.log('onChange called without handler', data);
+				uiLogger.warn('onChange called without handler', data);
 			},

As per coding guidelines: "Use the logger library exclusively for logging; DO NOT use console.log."

packages/components/src/data-table/index.web.tsx (2)

87-89: Replace console.log with logger.

Per coding guidelines, use the logger library exclusively. Consider importing the logger and replacing this debug statement.

Proposed fix

Add import at the top of the file:

import { getLogger } from '@wcpos/utils/logger';

const tableLogger = getLogger(['wcpos', 'components', 'data-table']);

Then update the handler:

 			onChange: (data: any) => {
-				console.log('onChange called without handler', data);
+				tableLogger.warn('onChange called without handler', data);
 			},

As per coding guidelines: "Use the logger library exclusively for logging; DO NOT use console.log."

---

66-66: Remove unused extraData prop.

The extraData prop is declared in the interface (line 36) and destructured (line 66), but it is not used anywhere in the component. Remove it from both the DataTableProps interface and the destructuring statement.

packages/components/src/data-table/index.tsx (1)

98-100: Replace console.log with logger and avoid any type.

This code violates the coding guidelines:

1. Uses console.log instead of the logger library
2. Uses any type for the data parameter

Proposed fix

+import { getLogger } from '@wcpos/utils/logger';
+
+const logger = getLogger(['wcpos', 'components', 'data-table']);
+
 meta: {
   expanded$,
   expandedRef,
-  onChange: (data: any) => {
-    console.log('onChange called without handler', data);
+  onChange: (data: unknown) => {
+    logger.warn('onChange called without handler', { context: { data } });
   },

As per coding guidelines: "Use the logger library exclusively for logging; DO NOT use console.log" and "Do not use 'any' type; use strict types and generics instead".