internal/memory/store_test.go (1)

1390-1426: Consider adding coverage for the "don't clobber existing filesystem path" invariant.

The PR description explicitly calls out: "guard the ON CONFLICT DO UPDATE so that a synthetic path==id fallback never overwrites an existing real filesystem path already stored." The current test exercises two empty-path projects and idempotent re-calls, but both re-call scenarios have existing.path == id already, so they don't actually hit the branch where the CASE must preserve a pre-existing real filesystem path against a synthetic path==id overwrite attempt.

A targeted test would directly exercise the core regression:

🧪 Suggested additional test

func TestEnsureProject_EmptyPath_DoesNotClobberFilesystemPath(t *testing.T) {
	s := testStore(t)
	ctx := context.Background()

	// Orchestrator registers the project with a real filesystem path first.
	const id = "a7293a04b38a"
	const fsPath = "/home/wayne/git/dingo"
	if err := s.EnsureProject(ctx, id, fsPath, "dingo"); err != nil {
		t.Fatalf("EnsureProject (fs): %v", err)
	}

	// MCP later calls with empty path for the same ID — must NOT overwrite fsPath.
	if err := s.EnsureProject(ctx, id, "", "dingo"); err != nil {
		t.Fatalf("EnsureProject (mcp): %v", err)
	}

	projects, err := s.ListProjects(ctx)
	if err != nil {
		t.Fatalf("ListProjects: %v", err)
	}
	for _, p := range projects {
		if p.ID == id && p.Path != fsPath {
			t.Errorf("expected path to remain %q, got %q", fsPath, p.Path)
		}
	}
}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@internal/memory/store_test.go` around lines 1390 - 1426, Add a new unit test
that verifies EnsureProject does not overwrite an existing real filesystem path
when later called with an empty path: use testStore() and EnsureProject(ctx, id,
fsPath, ...) to create a project with a real filesystem path, then call
EnsureProject(ctx, id, "", ...) and assert via ListProjects() that the project's
Path remains the original fsPath; name the test
TestEnsureProject_EmptyPath_DoesNotClobberFilesystemPath and reference
EnsureProject, ListProjects, and testStore to locate the relevant store API.