Skip to content

Minor test issues in setScanLimit() and setIntensity() methods #4

@bertsierra

Description

@bertsierra

I’ve spotted a couple of minor issues with the setScanLimit() and setIntensity() methods. The test ‘limit>=0 || limit<8’ on line 88 is always true, so spiTransfer is called even with bad limit values. Line 88 should be corrected as shown below:

if(limit>=0 && limit<8)

Similarly, on line 95 there is a test ‘intensity>=0 || intensity<16’ which is always true no matter what. Line 95 should be corrected as shown below:

if(intensity>=0 && intensity<16)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions