Merged
Conversation
Owner
|
@carpetscheme thanks so much! I'm definitely interested in this idea. I was also considering to add exif information. I'll probably refactor this into the approach that passing a format of string for alt text like "%ImageDescription% - %Artist%". |
Owner
|
@carpetscheme I made some refactoring on your PR.
|
Contributor
Author
|
Great idea! Much cleaner, nicely done. Thanks again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I wanted to enable showing captions for the photos, for a particular project. If you prefer not to add more complication then feel free to close the PR, I will happily keep a fork, but thought it may be of interest.
The change reads the EXIF 'Image Description' tag and adds it as an image alt tag. The photoswipe dynamic caption plugin is used to read this tag and show a caption.
Thanks for the tool in any case! Regards