Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore: enable errcheck linter and resolve linter warnings#167

Merged
LukeWinikates merged 1 commit intomasterfrom
errcheck
Sep 28, 2023
Merged

chore: enable errcheck linter and resolve linter warnings#167
LukeWinikates merged 1 commit intomasterfrom
errcheck

Conversation

@LukeWinikates
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@suprajanarasimhan suprajanarasimhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this change enables a linter for identifying and correcting unchecked errors.
The two types of corrections I see:

  • Assert that code in tests doesn't return errors.
  • Add underscores to indicate intentionally ignored errors.

Neat!

@LukeWinikates LukeWinikates merged commit 971d46f into master Sep 28, 2023
@LukeWinikates LukeWinikates deleted the errcheck branch October 11, 2023 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants