Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

fix: restore support for paths in URLs#134

Merged
LukeWinikates merged 1 commit intowavefrontHQ:masterfrom
LukeWinikates:fix-path-support
May 1, 2023
Merged

fix: restore support for paths in URLs#134
LukeWinikates merged 1 commit intowavefrontHQ:masterfrom
LukeWinikates:fix-path-support

Conversation

@LukeWinikates
Copy link
Copy Markdown
Contributor

@LukeWinikates LukeWinikates commented May 1, 2023

addresses #133

This PR restores support for paths in URLs passed to the Wavefront sender.

  • adds a top-level integration test for path support, so that it's less likely to break in the future
  • makes several helper funcs internal
  • moves sender package tests into sender package (so they can call non-public funcs)

@jbooherl
Copy link
Copy Markdown

jbooherl commented May 1, 2023

lgtm

@LukeWinikates LukeWinikates merged commit f767d37 into wavefrontHQ:master May 1, 2023
@LukeWinikates LukeWinikates deleted the fix-path-support branch May 1, 2023 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jbooherl jbooherl jbooherl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LukeWinikates @jbooherl