This repository was archived by the owner on Jan 16, 2026. It is now read-only.
feat: allow configuring flush interval using time.Duration#129
Merged
LukeWinikates merged 1 commit intowavefrontHQ:masterfrom Mar 3, 2023
LukeWinikates:flush-interval-duration
Merged
feat: allow configuring flush interval using time.Duration#129LukeWinikates merged 1 commit intowavefrontHQ:masterfrom LukeWinikates:flush-interval-duration
LukeWinikates merged 1 commit intowavefrontHQ:masterfrom
LukeWinikates:flush-interval-duration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see: /issues/121
I think we should keep the
FlushIntervalSecondsversion for now, but probably mark it as deprecated. I agree with @oppegard 's point in the linked issue that semantically it is better to express durations astime.Durationrather than asints.