Migrate rest of the cmdletd under StorageAccount to Track2 SDK #20
Closed
yifanz0 wants to merge 2 commits intowastoresh:track2reviewfrom
Closed
Migrate rest of the cmdletd under StorageAccount to Track2 SDK #20yifanz0 wants to merge 2 commits intowastoresh:track2reviewfrom
yifanz0 wants to merge 2 commits intowastoresh:track2reviewfrom
Conversation
blueww
reviewed
Jul 26, 2022
| Track2.BlobContainerResource blobContainerResource = this.StorageClientTrack2 | ||
| .GetBlobContainerResource(this.ResourceGroupName, this.StorageAccountName, this.Name).Get().Value; | ||
|
|
||
| //var container = this.StorageClient.BlobContainers.Get( |
blueww
reviewed
Jul 26, 2022
| //{ | ||
| // containerlistResult = this.StorageClient.BlobContainers.ListNext(containerlistResult.NextPageLink); | ||
| // WriteContainerList(containerlistResult); | ||
| //} |
blueww
requested changes
Jul 26, 2022
Member
blueww
left a comment
There was a problem hiding this comment.
Is there any left cmdlets?
If not, we should remove the Track1 SDK reference.
| // this.ResourceGroupName, | ||
| // this.StorageAccountName, | ||
| // this.ContainerName, | ||
| // this.Etag); |
| //this.StorageClient.BlobContainers.ObjectLevelWorm( | ||
| // this.ResourceGroupName, | ||
| // this.StorageAccountName, | ||
| // this.Name); |
Member
There was a problem hiding this comment.
remove the commented part
Same as below
| ParameterSetName = ActiveDirectoryDomainServicesForFileParameterSet)] | ||
| [ValidateNotNullOrEmpty] | ||
| public string ActiveDirectoryDomainGuid { get; set; } | ||
| public Guid ActiveDirectoryDomainGuid { get; set; } |
Member
There was a problem hiding this comment.
this is a breaking change.
We should iether keep the input type as string, or follow the breaking process to release it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes for migrating the rest of the cmdlets that lies under StorageAccount to Track2 SDK.
Cmdlets include:
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added