Add wasmtime_linker_allow_unknown_exports to C API#173
Merged
frank-emrich merged 2 commits intowasmfx:mainfrom May 15, 2024
Merged
Add wasmtime_linker_allow_unknown_exports to C API#173frank-emrich merged 2 commits intowasmfx:mainfrom
frank-emrich merged 2 commits intowasmfx:mainfrom
Conversation
Member
|
I guess the |
Author
|
No, it's a hardcoded list in the |
dhil
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C API for using the wasmtime linker currently only gives access to the
allow_shadowingsetting of the linker, but not to theallow_unknown_exportssetting. However, the latter setting needs to be enabled in order to allow exporting the global__stack_pointer. This is what's causing the issue described in wasmfx/waeio#2.(Alternatively, we may add
__stack_pointerto the list of blessed globals in thecommandfunction in crates/wasmtime/src/runtime/linker.rs, but the comments there suggest that new items shouldn't be added to that list. Therefore, just making this setting accessible in the C API seems less controversial.)