Skip to content

Add missing HtmlFormElement::request_submit method#3747

Merged
daxpedda merged 3 commits intowasm-bindgen:mainfrom
sciguy16:feature/form-request-submit
Dec 20, 2023
Merged

Add missing HtmlFormElement::request_submit method#3747
daxpedda merged 3 commits intowasm-bindgen:mainfrom
sciguy16:feature/form-request-submit

Conversation

@sciguy16
Copy link
Copy Markdown
Contributor

Add the HtmlFormElement::request_submit* methods that were missing from the IDL file in web-sys

https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/requestSubmit
https://html.spec.whatwg.org/#htmlformelement

Copy link
Copy Markdown
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a note in the changelog?
Otherwise LGTM!

@sciguy16 sciguy16 force-pushed the feature/form-request-submit branch from a3275a2 to 2905374 Compare December 20, 2023 17:57
@sciguy16
Copy link
Copy Markdown
Contributor Author

Thanks! I've updated the changelog

@daxpedda daxpedda merged commit a070715 into wasm-bindgen:main Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants