Skip to content

Update release workflow#3680

Open
ranile wants to merge 1 commit intomainfrom
hamza1311-patch-1
Open

Update release workflow#3680
ranile wants to merge 1 commit intomainfrom
hamza1311-patch-1

Conversation

@ranile
Copy link
Copy Markdown
Contributor

@ranile ranile commented Nov 2, 2023

Combine bump and release into a single step

Combine bump and release into a single step
@ranile ranile requested a review from daxpedda November 2, 2023 16:14
- run: rustc publish.rs
- name: assert we're on bump branch
run: test "$(git git branch --show-current)" = "bump"
- run: git commit -S -F /tmp/msg
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will GitHub handle -S for signed commits properly? Not sure

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No clue, worth the try.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See actions/runner#667

As far as I understand you can't with the default git config, but there are some workarounds.

Copy link
Copy Markdown
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants