-
Notifications
You must be signed in to change notification settings - Fork 15
refactor: replace direct ChatOpenAI usage with provider-agnostic get_chat_model function #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace direct ChatOpenAI usage with provider-agnostic get_chat_model function #18
Conversation
…chat_model function
…Garden support Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
|
@dimeloper any update? |
Guess you mentioned wrong GitHub user - btw, I've created a PR on top of your with important additions / fixes. Please have a look and let me know. Also, make you use the same GitHub account, I see your last comment left by a different account. |
|
Yeah, 😁looks like I mentioned someone else. |
|
@dkargatzis please let me know if you need any help on this? Or any other issue/feature. |
|
Completed the Google application and still awaiting the 20K credits to be topped up in our account. If the credits aren’t in place by tomorrow, I’ll proceed to merge and handle any follow-up PRs as part of the post-merge triage. Regarding Warestack onboarding - great news! I’m happy to assist you or run a live demo anytime. Your feedback is always welcome as we continue refining the experience. |
|
Hey @aryanraj2713, would you like to take a deeper look into the repo to align the tests? Happy to help out or handle it if it turns out to be too much. |
|
Sure, do you want to setup a meet? |
Sure @aryanraj2713! Feel to book a slot here |
|
@aryanraj2713 I noticed that you haven't created the calendar event - do you want me to handle this? |
|
Hey sorry, we had festivals here in India and I got busy, will try to schedule ASAP |
|
Cool, looking forward to our meet! |
|
Link is dead |
|
@aryanraj2713 the link says "A meeting has already been scheduled using this link." - we had a call a few days ago but you didn't join. Here is a new one - feel free to book a new meeting! |
Rationale
Related issue: closes #3
Summary of Changes
src/core/ai.pywithget_chat_model()factory supporting:langchain_openailangchain_aws(preferred) orlangchain_communityfallbacklangchain_google_vertexaiAIConfiginsrc/core/config.pywith provider-specific fields:bedrock_region,bedrock_model_idgcp_project,gcp_locationChatOpenAIusage withget_chat_model()in:src/agents/base.pysrc/agents/feasibility_agent/nodes.pysrc/agents/engine_agent/nodes.pysrc/agents/acknowledgment_agent/agent.pyBehavior Change
Configuration
AI_PROVIDER= openai | bedrock | gardenAI_MODEL,AI_MAX_TOKENS,AI_TEMPERATUREOPENAI_API_KEYBEDROCK_REGION(optional hint)BEDROCK_MODEL_ID(optional; falls back toAI_MODEL)GCP_PROJECT_ID(optional, recommended)GCP_LOCATION(optional, recommended)Optional dependencies (to be installed by users selecting these providers):
langchain-aws(preferred) orlangchain-communitylangchain-google-vertexaiPerformance
Security
Risk and Rollback
AI_PROVIDERis set accordingly.AI_PROVIDER=openaito use the default path; code remains compatible.CI
PR Checklist (per CONTRIBUTING)
Branch