Skip to content

feat(sweeps): forward signals received by wandb_agent to child processes#9651

Merged
domphan-wandb merged 14 commits intomainfrom
kyle/forward-agent-signals
Dec 8, 2025
Merged

feat(sweeps): forward signals received by wandb_agent to child processes#9651
domphan-wandb merged 14 commits intomainfrom
kyle/forward-agent-signals

Conversation

@KyleGoyette
Copy link
Copy Markdown
Contributor

@KyleGoyette KyleGoyette commented Mar 28, 2025 •
edited by domphan-wandb
Loading

Description

Docs PR: wandb/docs#1950

This PR adds a flag that allows agent signals to be forwarded to child runs. NVIDIA originally reported this and confirmed this solution works for them.

  • I updated CHANGELOG.unreleased.md, or it's not applicable

Testing

How was this PR tested?

  • Added unit tests to test:
    • catchable signals are registered
    • signals are sent to child subprocesses on windows and non-windows platforms
    • the sigkill signal calls _proc.kill
  • Added system test that sets up a parent / child scripts and sends sigterm to agent to verify the child run gets the signal.
  • NVIDIA tested

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@KyleGoyette KyleGoyette changed the title forward agent signals feat(sweeps): Forward signals received by wandb_agent to child processes Mar 28, 2025
@domphan-wandb domphan-wandb force-pushed the kyle/forward-agent-signals branch from da0e38d to b74ce57 Compare December 1, 2025 22:25
@dmitryduev
Copy link
Copy Markdown
Member

dmitryduev commented Dec 2, 2025

Closing as stale.

@dmitryduev dmitryduev closed this Dec 2, 2025
@domphan-wandb domphan-wandb reopened this Dec 2, 2025
@domphan-wandb domphan-wandb force-pushed the kyle/forward-agent-signals branch 3 times, most recently from 037c6c9 to 34f5184 Compare December 2, 2025 20:05
@domphan-wandb domphan-wandb changed the title feat(sweeps): Forward signals received by wandb_agent to child processes feat(sweeps): forward signals received by wandb_agent to child processes Dec 2, 2025
@domphan-wandb domphan-wandb force-pushed the kyle/forward-agent-signals branch from 34f5184 to 739f117 Compare December 2, 2025 21:40
@domphan-wandb domphan-wandb marked this pull request as ready for review December 2, 2025 22:34
@domphan-wandb domphan-wandb requested a review from a team as a code owner December 2, 2025 22:34
dmitryduev
dmitryduev reviewed Dec 5, 2025
View reviewed changes
Comment thread wandb/wandb_agent.py Outdated
Comment thread wandb/wandb_agent.py Outdated
@domphan-wandb domphan-wandb force-pushed the kyle/forward-agent-signals branch from 7abffb7 to 7112c61 Compare December 5, 2025 23:36
@domphan-wandb domphan-wandb enabled auto-merge (squash) December 6, 2025 01:06
@domphan-wandb domphan-wandb merged commit 8e2f467 into main Dec 8, 2025
25 checks passed
@domphan-wandb domphan-wandb deleted the kyle/forward-agent-signals branch December 8, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domphan-wandb domphan-wandb domphan-wandb left review comments

@dmitryduev dmitryduev dmitryduev approved these changes

@nicholaspun-wandb nicholaspun-wandb nicholaspun-wandb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KyleGoyette @dmitryduev @domphan-wandb @nicholaspun-wandb