Skip to content

fix(sweeps): test-only: ensure api.run works for sweeps runs#11097

Merged
kelu-wandb merged 10 commits intomainfrom
kelu/sweep-run
Dec 24, 2025
Merged

fix(sweeps): test-only: ensure api.run works for sweeps runs#11097
kelu-wandb merged 10 commits intomainfrom
kelu/sweep-run

Conversation

@kelu-wandb
Copy link
Copy Markdown
Contributor

@kelu-wandb kelu-wandb commented Dec 19, 2025 •
edited
Loading

Description

  • I updated CHANGELOG.unreleased.md, or it's not applicable

Testing

How was this PR tested?

Now passes, but fails if patched to run on code from before commit from #11088, e.g. git checkout 0e56797b2eef10b1a58d13373a0e690f1805d2c4
E wandb.errors.errors.CommError: Object of type Api is not JSON serializable

@kelu-wandb kelu-wandb changed the title fix(sweeps): Ensure api.run works for sweeps runs fix(sweeps): ensure api.run works for sweeps runs Dec 19, 2025
@kelu-wandb kelu-wandb marked this pull request as ready for review December 19, 2025 23:31
@kelu-wandb kelu-wandb requested a review from a team as a code owner December 19, 2025 23:31
@kelu-wandb kelu-wandb requested review from dmitryduev, timoffex and willtryagain and removed request for dmitryduev December 19, 2025 23:31
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

jacobromero
jacobromero reviewed Dec 20, 2025
View reviewed changes
Comment thread tests/system_tests/test_sweep/test_sweep_public_api.py Outdated
@kelu-wandb kelu-wandb enabled auto-merge (squash) December 22, 2025 18:53
@kelu-wandb kelu-wandb disabled auto-merge December 22, 2025 18:54
timoffex
timoffex approved these changes Dec 22, 2025
View reviewed changes
Comment thread tests/system_tests/test_sweep/test_sweep_public_api.py Outdated
Comment thread tests/system_tests/test_sweep/test_sweep_public_api.py Outdated
Comment thread tests/system_tests/test_sweep/test_sweep_public_api.py Outdated
Comment thread tests/system_tests/test_sweep/test_sweep_public_api.py Outdated
@kelu-wandb kelu-wandb changed the title fix(sweeps): ensure api.run works for sweeps runs fix(sweeps): test-only: ensure api.run works for sweeps runs Dec 24, 2025
kelu-wandb
kelu-wandb commented Dec 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@kelu-wandb kelu-wandb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated based on code review comments

@kelu-wandb kelu-wandb enabled auto-merge (squash) December 24, 2025 23:03
@kelu-wandb kelu-wandb merged commit e7d80d3 into main Dec 24, 2025
29 checks passed
@kelu-wandb kelu-wandb deleted the kelu/sweep-run branch December 24, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobromero jacobromero jacobromero approved these changes

@timoffex timoffex timoffex approved these changes

@willtryagain willtryagain Awaiting requested review from willtryagain

@KyleGoyette KyleGoyette Awaiting requested review from KyleGoyette

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kelu-wandb @jacobromero @timoffex