Enhance ja#594
Merged
Merged
Conversation
koji520
commented
May 6, 2025
Contributor
- Add JPSlashDateFormatParser
- Add JPTimeExpressionParser and JPMergeDateTimeRefiner
- Add JPWeekdayParser, JPWeekdayWithParenthesesParser and JPMergeWeekdayComponentRefiner
- Add JPMergeDateTimeRefiner
- Update ja/index to include common configuration
- Add tests related to the above
…h corresponding tests for time expressions
…merging date and weekday
…WeekdayParser and JPWeekdayWithParenthesesParser
…and pattern matching
… adjust refiner filtering
wanasit
reviewed
May 24, 2025
| expect(result.start).toBeDate(new Date(2012, 12 - 1, 31, 12)); | ||
| }); | ||
|
|
||
| testSingleCase(chrono.ja, "8/5", new Date(2012, 8 - 1, 10), (result) => { |
Owner
There was a problem hiding this comment.
You should also test zenkaku cases too.
wanasit
reviewed
May 24, 2025
| } | ||
|
|
||
| // ============================================================================================= | ||
| // Extracting the 'to' chunk |
Owner
There was a problem hiding this comment.
Please avoid full-page line comments like this. Other people (or your IDE vs Github) may have different screen width settings.
wanasit
approved these changes
May 24, 2025
Owner
|
Thanks for the improvement! |
Contributor
Author
|
@wanasit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.