Skip to content

Wait for kafka#435

Closed
hummerd wants to merge 1 commit intowait4x:mainfrom
hummerd:main
Closed

Wait for kafka#435
hummerd wants to merge 1 commit intowait4x:mainfrom
hummerd:main

Conversation

@hummerd
Copy link
Contributor

@hummerd hummerd commented Jun 21, 2025

Added command for waiting for Kafka server to be ready.

Also changed implementation of IsConnectionRefused - to be recursive, to handle wrapped errors.

@coveralls
Copy link

coveralls commented Jun 21, 2025

Pull Request Test Coverage Report for Build 15795850890

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 68 of 129 (52.71%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 48.508%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/cmd/root.go 0 1 0.0%
checker/utils.go 7 11 63.64%
checker/kafka/kafka.go 61 84 72.62%
internal/cmd/kafka.go 0 33 0.0%
Totals Coverage Status
Change from base Build 15795487659: 0.1%
Covered Lines: 1268
Relevant Lines: 2614
💛 - Coveralls

@atkrad
Copy link
Member

atkrad commented Jun 25, 2025

bugbot run

cursor[bot]
cursor bot reviewed Jun 25, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Build Tag Affects Kafka Command

The kafka.go file uses the incorrect build tag //go:build !disable_mongodb. This should be //go:build !disable_kafka, as the current tag incorrectly ties the Kafka command's build inclusion to MongoDB settings, potentially leading to compilation errors.

internal/cmd/kafka.go#L14-L15

wait4x/internal/cmd/kafka.go

Lines 14 to 15 in f64f9b5

//go:build !disable_mongodb

Fix in Cursor

BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

@atkrad atkrad self-requested a review June 25, 2025 13:56
@atkrad atkrad mentioned this pull request Jun 25, 2025
Merged
@atkrad
Copy link
Member

atkrad commented Jun 25, 2025

Hey @hummerd,

Thanks a lot for your contribution, I really appreciate it!
Since we need to support the Kafka disable feature like we do for the other services, I created a new PR (#439) based on your work and will close this one.

@atkrad atkrad closed this Jun 25, 2025
@hummerd
Copy link
Contributor Author

hummerd commented Jun 25, 2025

Ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@atkrad atkrad Awaiting requested review from atkrad

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hummerd @coveralls @atkrad