Skip to content

Add dns feature#181

Merged
atkrad merged 3 commits intomainfrom
add-dns-feature
Feb 23, 2025
Merged

Add dns feature#181
atkrad merged 3 commits intomainfrom
add-dns-feature

Conversation

@atkrad
Copy link
Member

@atkrad atkrad commented May 16, 2023

No description provided.

@mortymacs mortymacs changed the title WIP: Add dns feature Add dns feature Jun 3, 2023
@coveralls
Copy link

coveralls commented Jun 3, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 13483900151

Details

  • 352 of 639 (55.09%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 53.585%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/app/wait4x/cmd/root.go 0 1 0.0%
checker/dns/dns.go 8 12 66.67%
checker/dns/a/a.go 40 45 88.89%
checker/dns/mx/mx.go 41 46 89.13%
checker/dns/ns/ns.go 41 46 89.13%
checker/dns/txt/txt.go 41 46 89.13%
checker/dns/aaaa/aaaa.go 48 57 84.21%
checker/dns/cname/cname.go 49 58 84.48%
internal/app/wait4x/cmd/dns/dns.go 0 18 0.0%
internal/app/wait4x/cmd/dns/ns.go 14 40 35.0%
Totals Coverage Status
Change from base Build 13398963833: 0.6%
Covered Lines: 1136
Relevant Lines: 2120
💛 - Coveralls

@mortymacs
Copy link
Member

mortymacs commented Jun 3, 2023

The PR is ready 😉

@atkrad atkrad self-assigned this Jun 3, 2023
atkrad
atkrad commented Jun 3, 2023
View reviewed changes
atkrad
atkrad commented Jun 3, 2023
View reviewed changes
@atkrad atkrad added the feature New feature or request label Jun 3, 2023
@honwen
Copy link
Contributor

honwen commented Feb 6, 2025

any plan to merge this feature?

@atkrad
Copy link
Member Author

atkrad commented Feb 6, 2025

Hey @honwen, thanks for your message. The PR has some conflicts. @mortymacs plans to fix them over the weekend. Hopefully, I can merge it next week.

@mortymacs mortymacs force-pushed the add-dns-feature branch 4 times, most recently from 544772d to c84dafd Compare February 6, 2025 16:04
@mortymacs
Copy link
Member

mortymacs commented Feb 6, 2025

Hey @honwen, thanks for your message. The PR has some conflicts. @mortymacs plans to fix them over the weekend. Hopefully, I can merge it next week.

Done.

@honwen
Copy link
Contributor

honwen commented Feb 17, 2025

Hey @honwen, thanks for your message. The PR has some conflicts. @mortymacs plans to fix them over the weekend. Hopefully, I can merge it next week.

tks

mortymacs
mortymacs reviewed Feb 23, 2025
View reviewed changes
@atkrad atkrad merged commit 1d27891 into main Feb 23, 2025
6 of 7 checks passed
@atkrad atkrad deleted the add-dns-feature branch February 23, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mortymacs mortymacs mortymacs left review comments

Assignees

@atkrad atkrad

Labels

feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atkrad @coveralls @mortymacs @honwen