website/src/pages/changelog.mdx (1)

19-20: Fill in the placeholder PR link before merging

??? should be replaced with the actual pull-request number (4254).
Leaving placeholders in the changelog reduces traceability for users who rely on the document to navigate to the relevant discussions.

- - Added EventsOffAll to `windows.runtime`, fixes [#3136](https://github.com/wailsapp/wails/issues/3136) [PR](https://github.com/wailsapp/wails/pull/???) by [@FrancescoLuzzi](https://github.com/FrancescoLuzzi)
+ - Added EventsOffAll to `windows.runtime`, fixes [#3136](https://github.com/wailsapp/wails/issues/3136) [PR](https://github.com/wailsapp/wails/pull/4254) by [@FrancescoLuzzi](https://github.com/FrancescoLuzzi)

v2/internal/frontend/runtime/wrapper/runtime.js (1)

59-62: Minor slice-usage quirk can be simplified

let args = [eventName].slice.call(arguments); works, but the eventName array element is discarded immediately. Using Array.prototype.slice is clearer and avoids the superfluous allocation.

-    let args = [eventName].slice.call(arguments);
+    let args = Array.prototype.slice.call(arguments);

v2/internal/frontend/runtime/desktop/main.js (1)

91-99: Replace delete with undefined-assignment to avoid hidden perf costs

Static-analysis flagged two delete operations. In V8 (Chromium/WebView2) delete triggers dictionary-mode transitions and de-opts hidden classes. Setting the property to undefined preserves performance while achieving the same result.

-    delete window.wails.SetBindings;
+    window.wails.SetBindings = undefined;

 ...

-    delete window.wailsbindings;
+    window.wailsbindings = undefined;

🧰 Tools

🪛 Biome (1.9.4)

[error] 93-93: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

---

[error] 98-98: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

v2/internal/frontend/runtime/desktop/main.js (3)

16-18: Import of EventsOffAll looks correct – minor ordering nit

The new symbol is imported right after EventsOff, which is semantically fine.
If you keep the list roughly alphabetical (or grouped by “Off/OffAll/On/Once”) it becomes easier to scan when adding/removing future helpers.

---

55-61: Clarify the distinction between EventsOff and EventsOffAll

EventsOffAll is now exposed alongside EventsOff. Note that EventsOff() without arguments previously acted as a “remove-all” helper in several client snippets. Introducing a dedicated EventsOffAll may create two different public ways of clearing listeners or, worse, break older code that relied on the empty-arg behaviour of EventsOff.

1. Verify how EventsOff behaves when called with no arguments in events.js.
2. If both APIs coexist, consider:
   • Deprecating the empty-arg variant of EventsOff and documenting EventsOffAll as the canonical helper, or
   • Keeping only one public method and aliasing the other for backward compatibility (EventsOffAll = EventsOff).

This avoids confusion for downstream users and reduces surface area.

---

91-99: Avoid the delete operator for hot-path globals

Biome flags both delete calls as a performance hit. Replacing them with an undefined assignment prevents the hidden-class de-opt in V8 while achieving the same GC behaviour.

-    window.wails.SetBindings(window.wailsbindings);
-    delete window.wails.SetBindings;
+    window.wails.SetBindings(window.wailsbindings);
+    window.wails.SetBindings = undefined;
...
-    delete window.wailsbindings;
+    window.wailsbindings = undefined;

Because this runs at startup it’s not critical, yet it’s a free micro-optimisation and silences the linter.

🧰 Tools

🪛 Biome (1.9.4)

[error] 93-93: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

---

[error] 98-98: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

v2/internal/frontend/runtime/runtime_prod_desktop.js (2)

1-1: EventsOffAll correctly wired, but confirm listener-addition race

EventsOffAll (z) iterates over Object.keys(w) once and then calls p() to unregister each event.
If new listeners are registered during the loop they will survive because Object.keys was taken before the loop.
That’s fine for most use-cases, but if callers expect a strict “no listener survives” guarantee, you may want to:

function z() {
  // keep draining until empty – protects against races
  let names;
  while ((names = Object.keys(w)).length) {
    for (const n of names) p(n);
  }
}

Only worth changing if your runtime allows listener registration from inside EventsOff/OffAll callbacks.

🧰 Tools

🪛 Biome (1.9.4)

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Avoid redundant double-negation.

It is not necessary to use double-negation when a value will already be coerced to a boolean.
Unsafe fix: Remove redundant double-negation

(lint/complexity/noExtraBooleanCast)

---

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.

The declaration is defined in this switch clause:

Unsafe fix: Wrap the declaration in a block.

(lint/correctness/noSwitchDeclarations)

---

[error] 1-1: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

---

[error] 1-1: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

---

1-1: Same delete pattern as in main.js

For consistency and micro-perf reasons, consider the undefined assignment approach here as well (e.g. the two delete statements right after SetBindings).

🧰 Tools

🪛 Biome (1.9.4)

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Avoid redundant double-negation.

It is not necessary to use double-negation when a value will already be coerced to a boolean.
Unsafe fix: Remove redundant double-negation

(lint/complexity/noExtraBooleanCast)

---

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.

The declaration is defined in this switch clause:

Unsafe fix: Wrap the declaration in a block.

(lint/correctness/noSwitchDeclarations)

---

[error] 1-1: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

---

[error] 1-1: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

v2/internal/frontend/runtime/runtime_prod_desktop.js (1)

1-1: Consider using optional chaining for safer property access.

The static analysis identified several instances where optional chaining could be used to make property access safer, particularly when checking for existence of properties before accessing nested ones.

For example, in places where you check for window.chrome?.webview?.postMessageWithAdditionalObjects, using the optional chaining operator consistently would make the code more robust.

🧰 Tools

🪛 Biome (1.9.4)

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Avoid redundant double-negation.

It is not necessary to use double-negation when a value will already be coerced to a boolean.
Unsafe fix: Remove redundant double-negation

(lint/complexity/noExtraBooleanCast)

---

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.

The declaration is defined in this switch clause:

Unsafe fix: Wrap the declaration in a block.

(lint/correctness/noSwitchDeclarations)

---

[error] 1-1: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

---

[error] 1-1: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

v2/internal/frontend/runtime/runtime_prod_desktop.js (1)

1-1: Consider switching to optional chaining in future refactors.

There are multiple instances in the code where optional chaining could be used to improve readability and robustness, according to the static analysis hints.

-w[t]?.slice()||[]
+w[t]?.slice()??[]

-window.chrome?.webview?.postMessageWithAdditionalObjects!=null
+window.chrome?.webview?.postMessageWithAdditionalObjects!=null

-window.chrome?.webview?.postMessageWithAdditionalObjects
+window.chrome?.webview?.postMessageWithAdditionalObjects

🧰 Tools

🪛 Biome (1.9.4)

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Avoid redundant double-negation.

It is not necessary to use double-negation when a value will already be coerced to a boolean.
Unsafe fix: Remove redundant double-negation

(lint/complexity/noExtraBooleanCast)

---

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.

The declaration is defined in this switch clause:

Unsafe fix: Wrap the declaration in a block.

(lint/correctness/noSwitchDeclarations)

---

[error] 1-1: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

---

[error] 1-1: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

v2/internal/frontend/runtime/runtime_prod_desktop.js (3)

353-358: Consider performance impact of using delete operator

The static analysis hints suggest avoiding the delete operator for performance reasons. In functions like g(e) that use delete w[e], consider using an assignment to undefined instead (e.g., w[e] = undefined).

This change is optional but might offer a slight performance improvement, especially in performance-sensitive event handling code.

function g(e){
-  delete w[e],
+  w[e] = undefined,
   window.WailsInvoke("EX"+e)
}

---

240-242: Optional chaining opportunity for better readability

Multiple places in the code check for the existence of objects before accessing their properties. Consider using optional chaining for cleaner code, which is supported in modern browsers.

- function V(){return window.chrome?.webview?.postMessageWithAdditionalObjects!=null}
+ function V(){return window.chrome?.webview?.postMessageWithAdditionalObjects != null}

- function Me(e,t,n){window.chrome?.webview?.postMessageWithAdditionalObjects&&chrome.webview.postMessageWithAdditionalObjects(`file:drop:${e}:${t}`,n)}
+ function Me(e,t,n){window.chrome?.webview?.postMessageWithAdditionalObjects?.(`file:drop:${e}:${t}`,n)}

Also applies to: 257-257

---

1-1: Consider adding JSDoc comments for the new EventsOffAll function

While the implementation is correct, consider adding JSDoc comments to document the purpose and behavior of the new EventsOffAll function. This would improve maintainability and help other developers understand its intended use.

🧰 Tools

🪛 Biome (1.9.4)

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Avoid redundant double-negation.

It is not necessary to use double-negation when a value will already be coerced to a boolean.
Unsafe fix: Remove redundant double-negation

(lint/complexity/noExtraBooleanCast)

---

[error] 1-1: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 1-1: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.

The declaration is defined in this switch clause:

Unsafe fix: Wrap the declaration in a block.

(lint/correctness/noSwitchDeclarations)

---

[error] 1-1: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

---

[error] 1-1: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro