[linux] Add support for WebKit2GTK 2.36+ features#2151
Conversation
| | Feature | Win | Mac | Lin | | ||
| | ----------------------- | --- | --- | ------ | | ||
| | GET | ✅ | ✅ | ✅ | | ||
| | POST | ✅ | ✅ | ✅ [^1] | |
There was a problem hiding this comment.
@leaanthony , @misitebao does anybody of you know if that footnotes do work with our docs?
There was a problem hiding this comment.
Your best bet it to open branches on the repo itself then PRs will auto-deploy so you can see :-)
There was a problem hiding this comment.
Ah yeah, always forget about that 😄
There was a problem hiding this comment.
Hmm just seen your other PR and it seems footnotes are there for the next version docs: https://622b4565.wails.pages.dev/docs/next/reference/options#assetserver
There was a problem hiding this comment.
Oh my bad! I wondered why it looked like nothing had happened. The superscript 1 is super hard to click and it jumps to the bottom of the page. How about a * next to is with some text right under it or maybe another column with Linux (webkit 2.36+) in it?
There was a problem hiding this comment.
Sorry already merged 😔, but will open another PR to improve that.
ff64704 to
234d946
Compare
|
Confirmed working on |
| package linux | ||
|
|
||
| /* | ||
| #cgo linux pkg-config: gtk+-3.0 webkit2gtk-4.0 libsoup-2.4 |
There was a problem hiding this comment.
Is libsoup a new dependency that we need to add to our website and package manager code? It looks like it's already installed in Ubuntu 22.04 but might not be for others?
There was a problem hiding this comment.
WebKit2GTK uses libsoup internally, so I think it should not be possible to have WebKit2GTK installed without this dependency. But maybe it's better to be on the safe side and add it.
I'll add that as soon as we have merged the CLI refactoring so it doesn't interfere with that. Are you fine with that?
There was a problem hiding this comment.
Yeah sure, though I suspect you are right: it's probably installed by webkit2gtk anyway so no need to specify it 👍
|
#2152 merged, you should be good to go with this. |
234d946 to
6aa57b6
Compare
|
Awesome, thanks for approving 🙏 |
Fixes #1498