Check system for user installed Linux dependencies by leaanthony · Pull Request #1180 · wailsapp/wails

leaanthony · 2022-02-23T20:43:34Z

Attempts to discover the dependencies if not installed via the package manager.
The library discovery code is untested!

cloudflare-workers-and-pages · 2022-02-23T20:46:05Z

Deploying with Cloudflare Pages

Latest commit:	`7d0d51e`
Status:	✅ Deploy successful!
Preview URL:	https://02acd615.wails-website.pages.dev

View logs

pebbe · 2022-02-24T10:25:51Z

Better, but still not correct...

Dependency	Package Name		Status		Version
----------	------------		------		-------
*docker		docker.io		Installed	20.10.5+dfsg1
gcc		build-essential		Installed	10.2.1
libgtk-3	libgtk-3-dev		Available	3.24.24-4
libwebkit	libwebkit2gtk-4.0-dev	Available	2.34.6-1~deb11u1
npm		npm			Installed	8.5.0
pkg-config	pkg-config		Installed	0.29.2

However, after unset LANG I get:

Dependency	Package Name		Status		Version
----------	------------		------		-------
*docker		docker.io		Installed	20.10.5+dfsg1-1+deb11u1
gcc		build-essential		Installed	12.9
libgtk-3	libgtk-3-dev		Installed	3.24.24-4
libwebkit	libwebkit2gtk-4.0-dev	Installed	2.34.6-1~deb11u1
npm		npm			Installed	8.5.0
pkg-config	pkg-config		Installed	0.29.2-1

Here is the output for version v2.0.0-beta.31 after unset LANG:

Dependency	Package Name		Status		Version
----------	------------		------		-------
*docker		docker.io		Installed	20.10.5+dfsg1-1+deb11u1
gcc		build-essential		Installed	12.9
libgtk-3	libgtk-3-dev		Installed	3.24.24-4
libwebkit	libwebkit2gtk-4.0-dev	Installed	2.34.6-1~deb11u1
npm		npm			Available	7.5.2+ds-2
pkg-config	pkg-config		Installed	0.29.2-1

I have installed all mention packages through the package manager, except npm, which is too old.
So the fix is a partial fix.

leaanthony · 2022-02-24T11:10:15Z

Why would LANG change things? All I'm doing for the libraries is running pkg-config and checking if it finds the cflags for the given library

pebbe · 2022-02-24T17:37:52Z

~ apt list build-essential
Bezig met oplijsten... Klaar
build-essential/stable,now 12.9 amd64 [geïnstalleerd]
build-essential/stable 12.9 i386

~ unset LANG

~ apt list build-essential
Listing... Done
build-essential/stable,now 12.9 amd64 [installed]
build-essential/stable 12.9 i386

leaanthony · 2022-02-24T19:31:46Z

Nice catch @pebbe - I think we can fix this by setting LANG before shelling. Thanks for taking time to test 👍

leaanthony · 2022-02-26T00:06:11Z

@pebbe - I've added a change that will attempt to set LANG for the call. I'm unable to test this locally. Is there a more robust way to detect packages are installed?

pebbe · 2022-02-26T01:17:01Z

Perhaps this?

dpkg-query -W -f '${status}\t${package}\t${version}\n' docker* build-* libgtk* libwebkit* npm pkg-config

bh90210 · 2022-02-26T03:26:56Z

+			checker := checkerFunctions[dep.Name]
+			if checker != nil {
+				checkLocallyInstalled(checker, dep)
+				continue


is continue really needed here?

also the if on line 48 what protects us against?

bh90210 · 2022-02-26T03:49:21Z

+	var stdo, stde bytes.Buffer
+	cmd.Stdout = &stdo
+	cmd.Stderr = &stde
+	cmd.Env = append(os.Environ(), "LANG=en_US.utf8")


I am afraid that this fix wont cut it

$ locale LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE="fr_FR.UTF-8" LC_NUMERIC="fr_FR.UTF-8" LC_TIME="fr_FR.UTF-8" LC_COLLATE="fr_FR.UTF-8" LC_MONETARY="fr_FR.UTF-8" LC_MESSAGES="fr_FR.UTF-8" LC_PAPER="fr_FR.UTF-8" LC_NAME="fr_FR.UTF-8" LC_ADDRESS="fr_FR.UTF-8" LC_TELEPHONE="fr_FR.UTF-8" LC_MEASUREMENT="fr_FR.UTF-8" LC_IDENTIFICATION="fr_FR.UTF-8" LC_ALL=fr_FR.UTF-8

$ wails doctor Wails CLI v2.0.0-beta.test Scanning system - Please wait (this may take a long time)...Done. System ------ OS: Ubuntu Version: 20.04 ID: ubuntu Go Version: go1.17.1 Platform: linux Architecture: amd64 Package Manager: apt Dependency Package Name Status Version ---------- ------------ ------ ------- *docker docker.io Installed 20.10.12 gcc build-essential Installed 9.3.0 libgtk-3 libgtk-3-dev Available 3.24.20-0ubuntu1 libwebkit libwebkit2gtk-4.0-dev Available 2.34.4-0ubuntu0.20.04.1 npm npm Installed 8.3.1 pkg-config pkg-config Installed 0.29.1 * - Optional Dependency Diagnosis --------- Your system has missing dependencies! Required package(s) installation details: - libgtk-3: sudo apt install libgtk-3-dev - libwebkit: sudo apt install libwebkit2gtk-4.0-dev

I am looking into it brb

bh90210 · 2022-02-26T04:16:15Z

+	var stdo, stde bytes.Buffer
+	cmd.Stdout = &stdo
+	cmd.Stderr = &stde
+	cmd.Env = append(os.Environ(), "LANG=en_US.utf8")


please change line 69 to

cmd.Env = append(os.Environ(), "LC_ALL=en_US.utf8")

$ locale LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE="fr_FR.UTF-8" LC_NUMERIC="fr_FR.UTF-8" LC_TIME="fr_FR.UTF-8" LC_COLLATE="fr_FR.UTF-8" LC_MONETARY="fr_FR.UTF-8" LC_MESSAGES="fr_FR.UTF-8" LC_PAPER="fr_FR.UTF-8" LC_NAME="fr_FR.UTF-8" LC_ADDRESS="fr_FR.UTF-8" LC_TELEPHONE="fr_FR.UTF-8" LC_MEASUREMENT="fr_FR.UTF-8" LC_IDENTIFICATION="fr_FR.UTF-8" LC_ALL=fr_FR.UTF-8

$ wails doctor Wails CLI v2.0.0-beta.test Scanning system - Please wait (this may take a long time)...Done. System ------ OS: Ubuntu Version: 20.04 ID: ubuntu Go Version: go1.17.1 Platform: linux Architecture: amd64 Package Manager: apt Dependency Package Name Status Version ---------- ------------ ------ ------- *docker docker.io Installed 20.10.12 gcc build-essential Installed 12.8ubuntu1.1 libgtk-3 libgtk-3-dev Installed 3.24.20-0ubuntu1 libwebkit libwebkit2gtk-4.0-dev Installed 2.34.4-0ubuntu0.20.04.1 npm npm Installed 8.3.1 pkg-config pkg-config Installed 0.29.1-0ubuntu4 * - Optional Dependency Diagnosis --------- Your system is ready for Wails development!

https://stackoverflow.com/questions/43953328/how-to-set-locale-in-the-current-terminals-session

bh90210 · 2022-02-26T13:24:16Z

#1179

Co-authored-by: stffabi <stffabi@users.noreply.github.com>

leaanthony · 2022-03-07T10:31:07Z

Do we think this can be merged?

leaanthony · 2022-03-15T09:25:10Z

Merging this as it appears to be better than what we have.

leaanthony requested a review from bh90210 February 23, 2022 20:44

stffabi reviewed Feb 24, 2022

View reviewed changes

Comment thread v2/internal/system/system_linux.go Outdated

bh90210 reviewed Feb 26, 2022

View reviewed changes

bh90210 suggested changes Feb 26, 2022

View reviewed changes

bh90210 approved these changes Feb 27, 2022

View reviewed changes

leaanthony and others added 5 commits March 7, 2022 21:18

[linux] Fix discovery of other deps

23a340b

Update v2/internal/system/system_linux.go

4ce0f4c

Co-authored-by: stffabi <stffabi@users.noreply.github.com>

Try setting locale before running apt

66dd37f

Use LC_ALL

ca1e263

Remove continue

7d0d51e

leaanthony force-pushed the bugfix/linux-deps branch from 9a45e82 to 7d0d51e Compare March 7, 2022 10:23

leaanthony merged commit d7395fc into master Mar 15, 2022

leaanthony deleted the bugfix/linux-deps branch March 15, 2022 09:25

coderabbitai Bot mentioned this pull request Apr 22, 2024

docs: add guides ide change goland option and reference cli add options vscode or goland #3419

Merged

1 task

Uh oh!

Conversation

leaanthony commented Feb 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages Bot commented Feb 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Pages

Uh oh!

Uh oh!

pebbe commented Feb 24, 2022

Uh oh!

leaanthony commented Feb 24, 2022

Uh oh!

pebbe commented Feb 24, 2022

Uh oh!

leaanthony commented Feb 24, 2022

Uh oh!

leaanthony commented Feb 26, 2022

Uh oh!

pebbe commented Feb 26, 2022

Uh oh!

bh90210 Feb 26, 2022

Choose a reason for hiding this comment

Uh oh!

bh90210 Feb 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bh90210 Feb 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bh90210 commented Feb 26, 2022

Uh oh!

leaanthony commented Mar 7, 2022

Uh oh!

leaanthony commented Mar 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

leaanthony commented Feb 23, 2022 •

edited

Loading

cloudflare-workers-and-pages Bot commented Feb 23, 2022 •

edited

Loading

bh90210 Feb 26, 2022 •

edited

Loading

bh90210 Feb 26, 2022 •

edited

Loading