fix(linter): address review feedback on full_comment_delete_span#1
Merged
wagenet merged 2 commits intostray-commentsfrom Feb 27, 2026
Merged
Conversation
…st submodule Co-authored-by: wagenet <9835+wagenet@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues raised in comments for PR 19804
fix(linter): address review feedback on full_comment_delete_span
Feb 27, 2026
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
autofix.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses two review comments from the
full_comment_delete_spanPR.Changes
debug_assert!in unreachable branch: Theelsefallback infull_comment_delete_span(where the content span isn't preceded by//or/*) now asserts false with an explanatory message, making the invariant violation visible in debug buildsmod full_comment_delete_span { ... }wrapper around the unit tests was removed; the 8 test functions now live directly in the parentmod tests, withfull_comment_delete_spanadded to the existinguse super::import🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.