Spacing adjustments #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<textarea>s have a 2px padding on both Chrome & Firefox. <pre>s, however, don't, which makes for miniscule text jumps between index.html & paste.html.
The line-height on the paste submission form & the paste display page is currently effectively different (due to <code>::before padding-bottom). This commit makes the line height uniform on both pages (leaning towards a higher value for better readability).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal for this PR is to make the line height uniform between the paste submission page & the display page. For example, here's how they are different now:
The paste display page has a much higher line-height.
In the version submitted in this PR, they are identical, which IMO looks nicer:
Please tell me if you like this.