Skip to content

Amend Standard Protocol Grant and add milestone 2#732

Closed
hskang9 wants to merge 4 commits intow3f:masterfrom
hskang9:master
Closed

Amend Standard Protocol Grant and add milestone 2#732
hskang9 wants to merge 4 commits intow3f:masterfrom
hskang9:master

Conversation

@hskang9
Copy link
Copy Markdown
Contributor

@hskang9 hskang9 commented Dec 8, 2021 •
edited
Loading

Project Abstract

Standard Protocol adds a new milestone reflecting current developer infrastructure.

Application Checklist

  • The application template has been copied, renamed ( project_name.md) and updated.
  • A BTC or Ethereum (DAI/USDT) address for the payment of the milestones is provided inside the application.
  • I have read and acknowledged the terms and conditions.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 8, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hskang9 hskang9 mentioned this pull request Dec 8, 2021
Merged
6 tasks
Noc2
Noc2 suggested changes Dec 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the amendment. Could you sign the latest version of the cla? Also are the 10 DAI on purpose? It might cost more to transfer the 10 Dai, so I would suggest either to reduce it to 0 DAI or to integrate the 10 DAI into another milestone.

@Noc2 Noc2 self-assigned this Dec 8, 2021
@Noc2 Noc2 added changes requested The team needs to clarify a few things first. amendment This PR proposes changes to an existing application. labels Dec 8, 2021
@hskang9
Copy link
Copy Markdown
Contributor Author

hskang9 commented Dec 10, 2021

@Noc2 0 dai is fine.

@Noc2
Copy link
Copy Markdown
Contributor

Noc2 commented Dec 10, 2021

In this case, could you update the PR?

@semuelle
Copy link
Copy Markdown
Contributor

semuelle commented Dec 15, 2021

ping @hskang9

alxs
alxs suggested changes Jan 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@alxs alxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hskang9 please commit so that we can review the amendment. When do you expect to deliver this new milestone? The PR has been opened for almost a month now, so if the estimate is anything to go by it's almost due.

applications/Standard_Protocol.md
### Milestone 2 - Oracle EVM precompile
* **Estimated Duration:** 1 month
* **FTE:** 1
* **Costs:** 10DAI
Copy link
Copy Markdown
Contributor

@alxs alxs Jan 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **Costs:** 10DAI
* **Costs:** 0DAI

@alxs alxs mentioned this pull request Jan 31, 2022
Merged
@alxs alxs closed this Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@alxs alxs alxs requested changes

@Noc2 Noc2 Noc2 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Noc2 Noc2

Labels

amendment This PR proposes changes to an existing application. changes requested The team needs to clarify a few things first.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hskang9 @CLAassistant @Noc2 @semuelle @alxs