Conversation
|
Why do you think it doesn't hold anything meaningful? How is it more convenient for participants? This only overrides the settings at a project level, so it shouldn't interfere with other settings or projects. |
I mean meaningful to 'business' data serving repository's objective (on its own) - working with grants applications and rfps.
Real example comes from my particular case: That's not a huge problem for myself, but as I see hundreds of contributors to this same repo, and more are expected to come, I thought such a fix could be helpful |
mmagician
left a comment
There was a problem hiding this comment.
Makes sense, editor-specific settings shouldn't be part of the repo
Do you have a better suggestion for sharing linting rules so our linters don't interfere with each other? Something that doesn't require manual updating? |
|
How is this file causing conflicts? I don't agree with merging this. If you don't use markdownlint, the file has no effect. If you edit the file, just don't commit it. The only people working on the same files is the grants team, and even if it's not common to have settings in a public repo, the advantages outweigh the disadvantages unless I'm misunderstanding how peacock or others are affected by it. |
I suppose
.vscode/settings.jsonis expected to differ at each user`s preferences.As it is unlikely to hold any meaningful value to the Grant Program to the point, this PR proposes to move it out from this repo, in convenience of participating members.